Re: [PATCH 1/5] http-protocol.txt: document SHA-256 "want"/"have" format

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Aug 14, 2020, 20:23 UTC
Message-ID: <20200814202347.GN8085@camp.crustytoothpaste.net>
In-Reply-To: <xmqqk0y1xhl0.fsf@gitster.c.googlers.com>

On 2020-08-14 at 17:28:27, Junio C Hamano wrote:

Show 7 quoted lines

> Martin Ågren <martin.agren@gmail.com> writes:
> 
> > Document that in SHA-1 repositories, we use SHA-1 for "want"s and
> > "have"s, and in SHA-256 repositories, we use SHA-256.
> 
> Ehh, doesn't this directly contradict the transition plan of "on the
> wire everything will use SHA-1 version for now?"

SHA-256 repositories interoperate currently using SHA-256 object IDs. It was originally intended that we wouldn't update the protocol, but that leads to much of the testsuite failing since it's impossible to move objects from one place to another.

If we wanted to be more pedantically correct and optimize for the future, we could say that the values use the format negotiated by the "object-format" protocol extension and SHA-1 otherwise.

-- 
brian m. carlson: Houston, Texas, US