git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] connected: use buffered I/O to talk to rev-list

From
Jeff King <peff@peff.net>
Date
Aug 13, 2020, 09:16 UTC
Message-ID
<20200813091643.GE3092220@coredump.intra.peff.net>
In-Reply-To
<2e3ac6f7-77c2-4792-d6df-891ede6318ce@web.de>
On Wed, Aug 12, 2020 at 06:52:49PM +0200, René Scharfe wrote:
Show 8 quoted lines
> Like f0bca72dc77 (send-pack: use buffered I/O to talk to pack-objects,
> 2016-06-08), significantly reduce the number of system calls and
> simplify the code for sending object IDs to rev-list by using stdio's
> buffering.
> 
> Take care to handle errors immediately to get the correct error code,
> and to flush the buffer explicitly before closing the stream in order to
> catch any write errors for these last bytes.

FWIW, the error handling in this patch and the other stdio conversions you sent all look good to me. Thanks (and to Chris and Johannes for great review on v1).

-Peff
Previous: René Scharfe
Message 5 of 5 in “connected: use buffered I/O to talk to rev-list”
  1. connected: use buffered I/O to talk to rev-listRené Scharfe, Aug 2, 2020
  2. Chris TorekAug 2, 2020
  3. Johannes SixtAug 3, 2020
  4. connected: use buffered I/O to talk to rev-listRené Scharfe, Aug 12, 2020
  5. Jeff KingAug 13, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.