Re: [PATCH v2] gitweb: map names/emails with mailmap
- From
Emma Brooks <me@pluvano.com>
- Date
- Aug 11, 2020, 04:17 UTC
- Message-ID
- <20200811041728.GA1748@pluvano.com>
- In-Reply-To
- <20200810100249.GC37030@coredump.intra.peff.net>
On 2020-08-10 06:02:49-0400, Jeff King wrote:
Show 6 quoted lines
> There was a little discussion in response to v1 on whether we could > reuse the existing C mailmap code: > > https://lore.kernel.org/git/20200731010129.GD240563@coredump.intra.peff.net/ > > Did you have any thoughts on that?
I think it's probably not worth the effort to make the necessary changes to "rev-list --header" Junio mentioned, just for gitweb.
I agree it's a bit worrisome to have a second parser that could potentially behave slightly differently than the main implementation. What if we added tests for gitweb's mailmap parsing based on the same cases used for Git itself?