git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Revert "contrib: subtree: adjust test to change in fmt-merge-msg"

From
Emily Shaffer <emilyshaffer@google.com>
Date
Aug 3, 2020, 18:57 UTC
Message-ID
<20200803185749.1441344-1-emilyshaffer@google.com>
This reverts commit 508fd8e8baf3e18ee40b2cf0b8899188a8506d07.

In 6e6029a8 (fmt-merge-msg: allow merge destination to be omitted again) we get back the behavior where merges against 'master', by default, do not include "into 'master'" at the end of the merge message. This test fix is no longer needed.

Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
---

I don't think anybody else sent this yet. Because the default value of merge.suppressDest suppresses 'master', the commit messages are wrong again for these tests. Noticed during a release for $DAYJOB. Thanks - looks like Linus was right that we get to remove lots more instances of 'master' from codebase with that config patch.

 - Emily
 contrib/subtree/t/t7900-subtree.sh | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/contrib/subtree/t/t7900-subtree.sh b/contrib/subtree/t/t7900-subtree.sh
index 53d7accf94..57ff4b25c1 100755
--- a/contrib/subtree/t/t7900-subtree.sh
+++ b/contrib/subtree/t/t7900-subtree.sh
@@ -196,8 +196,7 @@ test_expect_success 'merge new subproj history into sub dir/ with --prefix' '
 		cd "$subtree_test_count" &&
 		git fetch ./"sub proj" master &&
 		git subtree merge --prefix="sub dir" FETCH_HEAD &&
-		check_equal "$(last_commit_message)" \
-			"Merge commit '\''$(git rev-parse FETCH_HEAD)'\'' into master"
+		check_equal "$(last_commit_message)" "Merge commit '\''$(git rev-parse FETCH_HEAD)'\''"
 	)
 '
 
@@ -274,8 +273,7 @@ test_expect_success 'merge new subproj history into subdir/ with a slash appende
 		cd "$test_count" &&
 		git fetch ./subproj master &&
 		git subtree merge --prefix=subdir/ FETCH_HEAD &&
-		check_equal "$(last_commit_message)" \
-			"Merge commit '\''$(git rev-parse FETCH_HEAD)'\'' into master"
+		check_equal "$(last_commit_message)" "Merge commit '\''$(git rev-parse FETCH_HEAD)'\''"
 	)
 '
 
-- 
2.28.0.163.g6104cc2f0b6-goog
Next: Junio C Hamano
Message 1 of 4 in “Revert "contrib: subtree: adjust test to change in fmt-merge-msg"”
  1. Revert "contrib: subtree: adjust test to change in fmt-merge-msg"Emily Shaffer, Aug 3, 2020
  2. Junio C HamanoAug 3, 2020
  3. Emily ShafferAug 3, 2020
  4. Derrick StoleeAug 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.