git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] worktree: drop unused code from get_linked_worktree()

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 31, 2020, 23:32 UTC
Message-ID
<20200731233214.22131-3-sunshine@sunshineco.com>
In-Reply-To
<20200731233214.22131-1-sunshine@sunshineco.com>

This code has been unused since fa099d2322 (worktree.c: kill parse_ref() in favor of refs_resolve_ref_unsafe(), 2017-04-24), so drop it.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
Notes:
    This is a companion to 02bbbe9df9 (worktree: drop unused code from
    get_main_worktree(), 2020-02-23), which also cleaned up fallout from
    fa099d2322 (worktree.c: kill parse_ref() in favor of
    refs_resolve_ref_unsafe(), 2017-04-24).
 worktree.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/worktree.c b/worktree.c
index c0df5e2c79..fa8366a3ca 100644
--- a/worktree.c
+++ b/worktree.c
@@ -90,9 +90,6 @@ static struct worktree *get_linked_worktree(const char *id)
 		strbuf_strip_suffix(&worktree_path, "/.");
 	}
 
-	strbuf_reset(&path);
-	strbuf_addf(&path, "%s/worktrees/%s/HEAD", get_git_common_dir(), id);
-
 	worktree = xcalloc(1, sizeof(*worktree));
 	worktree->path = strbuf_detach(&worktree_path, NULL);
 	worktree->id = xstrdup(id);
-- 
2.28.0.203.gce1f2e0ef1
Previous: Eric SunshineNext: Eric Sunshine
Message 3 of 5 in “worktree: cleanups & simplification”
  1. 0/4 worktree: cleanups & simplificationEric Sunshine, Jul 31, 2020
  2. 3/4 worktree: drop bogus and unnecessary path mungingEric Sunshine, Jul 31, 2020
  3. 2/4 worktree: drop unused code from get_linked_worktree()Eric Sunshine, Jul 31, 2020
  4. 4/4 worktree: retire special-case normalization of main worktree pathEric Sunshine, Jul 31, 2020
  5. 1/4 worktree: drop pointless strbuf_release()Eric Sunshine, Jul 31, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.