Re: [PATCH] [RFC] travis-ci: remove bogus 'pyenv' in the Linux jobs
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Jul 21, 2020, 22:20 UTC
- Message-ID
- <20200721222004.GA1667453@crustytoothpaste.net>
- In-Reply-To
- <20200721161225.6769-1-szeder.dev@gmail.com>
On 2020-07-21 at 16:12:25, SZEDER Gábor wrote:
Show 15 quoted lines
> In our test suite, when 'git p4' invokes a Git command as a > subprocesses, then it should run the 'git' binary we are testing. > Unfortunately, this is not the case in the 'linux-clang' and > 'linux-gcc' jobs on Travis CI, where 'git p4' runs the system > '/usr/bin/git' instead. > > Travis CI's default Linux image includes 'pyenv', and all Python > invocations that involve PATH lookup go through 'pyenv', e.g. our > 'PYTHON_PATH=$(which python3)' sets '/opt/pyenv/shims/python3' as > PYTHON_PATH, which in turn will invoke '/usr/bin/python3'. Alas, the > 'pyenv' version included in this image is buggy, and prepends the > directory containing the Python binary to PATH even if that is a > system directory already in PATH near the end. Consequently, 'git p4' > in those jobs ends up with its PATH starting with '/usr/bin', and then > runs '/usr/bin/git'.
Ouch. So we're testing git-p4, but not the git binary underlying it. Fixing this definitely seems like a good idea.
-- brian m. carlson: Houston, Texas, US