git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] Support nvim as merge tool

From
pudinha <rogi@skylittlesystem.org>
Date
Jul 19, 2020, 04:23 UTC
Message-ID
<20200719042335.3913-1-rogi@skylittlesystem.org>
In-Reply-To
<20200718192001.27434-1-rogi@skylittlesystem.org>
Show 14 quoted lines
> For example, we could add another method the backends could define,
> call it list_tool_variants, and whenever the control flow goes from
> run_merge_tool through setup_tool for a tool whose name ends with
> [1-9], e.g. "foomerge3", we first see if there is "foomerge" tool
> and if there is ask it if it knows about "foomerge3" variant by
> calling its list_tool_variants.
>
> That way, we probably can remove the files for vimdiff2, vimdiff3,
> gvimdiff2 and gvimdiff3 (gvimdiff needs to stay there, as we do not
> want to make the name derivation rule too complex) only to hold a
> single line ". vimdiff".  Then the next person who adds yet another
> set of backends based on a yet another reimplementation or skin of
> vim would only have to add a single file in mergetools/ directory,
> not three.
This is what I managed to do.
pudinha (2):
  Refactor vimdiff and bc merge tool variants
  Support nvim as merge tool
 contrib/completion/git-completion.bash |  4 +--
 git-mergetool--lib.sh                  | 35 ++++++++++++++++++++------
 mergetools/bc                          |  5 ++++
 mergetools/bc3                         |  1 -
 mergetools/gvimdiff3                   |  1 -
 mergetools/{gvimdiff2 => nvimdiff}     |  0
 mergetools/vimdiff                     | 21 ++++++++++++----
 mergetools/vimdiff2                    |  1 -
 mergetools/vimdiff3                    |  1 -
 9 files changed, 51 insertions(+), 18 deletions(-)
 delete mode 100644 mergetools/bc3
 delete mode 100644 mergetools/gvimdiff3
 rename mergetools/{gvimdiff2 => nvimdiff} (100%)
 delete mode 100644 mergetools/vimdiff2
 delete mode 100644 mergetools/vimdiff3
-- 
2.27.0
Previous: Junio C HamanoNext: pudinha
Message 5 of 10 in “Support nvim as mergetool”
  1. Support nvim as mergetoolpudinha, Jul 18, 2020
  2. Junio C HamanoJul 18, 2020
  3. 1/2 Refactor vimdiff and bc merge tool variantspudinha, Jul 19, 2020
  4. Junio C HamanoJul 20, 2020
  5. 0/2 Support nvim as merge toolpudinha, Jul 19, 2020
  6. 0/2 mergetools: add support for nvimdiff (neovim) familypudinha, Jul 29, 2020
  7. 1/2 mergetool--lib: improve support for vimdiff-style tool variantspudinha, Jul 29, 2020
  8. 2/2 mergetools: add support for nvimdiff (neovim) familypudinha, Jul 29, 2020
  9. 2/2 Support nvim as merge toolpudinha, Jul 19, 2020
  10. Junio C HamanoJul 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.