git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] bundle: improve message when unknown hash algorithm detected

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jul 12, 2020, 16:50 UTC
Message-ID
<20200712165005.705979-1-sandals@crustytoothpaste.net>

The current code states "unknown hash algorithm length". This is slightly confusing, and moreover, we've gotten feedback that it's hard to translate into other languages. Since the case is that we cannot detect the hash algorithm, let's just say that. This is clearer and more direct, reflects the intent of the code (which calls the function detect_hash_algo just a few lines above), and will be easier to translate.

Suggested-by: Matthias Rüster <matthias.ruester@gmail.com>
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
Matthias contacted me privately about this message and I thought since
we're still in the RC period, it would make sense to include this in to
help translators and those who aren't native speakers.
 bundle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bundle.c b/bundle.c
index 2a0d744d3f..69c807bda9 100644
--- a/bundle.c
+++ b/bundle.c
@@ -66,7 +66,7 @@ static int parse_bundle_header(int fd, struct bundle_header *header,
 		if (!header->hash_algo) {
 			header->hash_algo = detect_hash_algo(&buf);
 			if (!header->hash_algo) {
-				error(_("unknown hash algorithm length"));
+				error(_("unable to detect hash algorithm"));
 				status = -1;
 				break;
 			}
Next: Junio C Hamano
Message 1 of 2 in “bundle: improve message when unknown hash algorithm detected”
  1. bundle: improve message when unknown hash algorithm detectedbrian m. carlson, Jul 12, 2020
  2. Junio C HamanoJul 12, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.