Re: [BUG] Installing git-gui (2.27.0)

From: Pratyush Yadav <me@yadavpratyush.com>
Date: Jun 23, 2020, 12:47 UTC
Message-ID: <20200623124726.3f3g7gmm7zfwxvhu@yadavpratyush.com>
In-Reply-To: <00dd01d63d9d$65f5dda0$31e198e0$@nexbridge.com>

Hi Randall,

On 08/06/20 10:02AM, Randall S. Becker wrote:

Show 30 quoted lines

> Hi,
> 
> This is what I found when trying to install the whole git package on the
> NonStop TNS/E platform:
> 
>  DEST /usr/local/share/git-gui/lib
>     INSTALL 644 tclIndex
> install: cannot stat 'lib/tclIndex': No such file or directory
> Makefile:293: recipe for target 'install' failed
> 
> Im not sure why we are only hitting this now at 2.27.0. We dont use
> git-gui anyway on this platform as it has no GUI interface. It looks like
> the install script runs auto_mkindex that actually does nothing in our case,
> so lib/tclIndex is not built.
> 
> This does block the install from completing successfully. To bypass, I added
> the following:
> 
> index f10caedaa7..943febaf75 100644
> --- a/git-gui/Makefile
> +++ b/git-gui/Makefile
> @@ -256,6 +256,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
>           $(foreach p,$(PRELOAD_FILES),source $p\;) \
>           auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \
>         | $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \
> +        echo >>$@ ; \
>         else \
>          echo >&2 "    * $(TCL_PATH) failed; using unoptimized loading"; \
>          rm -f $@ ; \
>

IIUC, this is a NonStop-specific problem. This fix shouldn't go in the git-gui 'master', right?

-- 
Regards,
Pratyush Yadav