[PATCH 0/2] drop specialized knowledge from generic worktree code
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jun 19, 2020, 23:35 UTC
- Message-ID
- <20200619233544.42025-1-sunshine@sunshineco.com>
This patch series removes specialized knowledge from the libified worktree code about how front-end "git worktree list" wants worktrees sorted, and instead makes it the responsibility of "git worktree list" itself to do the sorting.
It is built atop es/worktree-duplicate-paths since that series adds another caller of get_worktrees() which this series touches.
A possible argument against this patch series is that some other entity may someday want worktrees sorted in the same fashion as "git worktree list", however, that seems a case of YAGNI.
Eric Sunshine (2): worktree: drop get_worktrees() special-purpose sorting option worktree: drop get_worktrees() unused 'flags' argument
branch.c | 2 +- builtin/branch.c | 2 +- builtin/config.c | 2 +- builtin/fsck.c | 2 +- builtin/reflog.c | 2 +- builtin/worktree.c | 32 ++++++++++++++++++++++++++------ ref-filter.c | 2 +- revision.c | 4 ++-- t/helper/test-ref-store.c | 2 +- worktree.c | 20 +++----------------- worktree.h | 11 +++-------- 11 files changed, 41 insertions(+), 40 deletions(-)
-- 2.27.0.221.g4d328a12d9