[PATCH v2 2/7] worktree: give "should be pruned?" function more meaningful name
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jun 10, 2020, 06:30 UTC
- Message-ID
- <20200610063049.74666-3-sunshine@sunshineco.com>
- In-Reply-To
- <20200610063049.74666-1-sunshine@sunshineco.com>
Readers of the name prune_worktree() are likely to expect the function to actually prune a worktree, however, it only answers the question "should this worktree be pruned?". Give it a name more reflective of its true purpose to avoid such confusion.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> --- builtin/worktree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/worktree.c b/builtin/worktree.c index 9b15f19fc5..35d38607e7 100644 --- a/builtin/worktree.c +++ b/builtin/worktree.c @@ -67,7 +67,7 @@ static void delete_worktrees_dir_if_empty(void) rmdir(git_path("worktrees")); /* ignore failed removal */ } -static int prune_worktree(const char *id, struct strbuf *reason) +static int should_prune_worktree(const char *id, struct strbuf *reason) { struct stat st; char *path; @@ -144,7 +144,7 @@ static void prune_worktrees(void) if (is_dot_or_dotdot(d->d_name)) continue; strbuf_reset(&reason); - if (!prune_worktree(d->d_name, &reason)) + if (!should_prune_worktree(d->d_name, &reason)) continue; if (show_only || verbose) printf_ln(_("Removing %s/%s: %s"),
-- 2.27.0.90.gabb59f83a2