Re: [PATCH 0/2] t5318: test '--stdin-commits' with '--[no-]progress'

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 1, 2020, 19:36 UTC
Message-ID: <20200601193648.GA32262@syl.local>
In-Reply-To: <153faa41-2801-d6bc-1f48-05a0ac08b446@gmail.com>

On Mon, Jun 01, 2020 at 03:35:31PM -0400, Derrick Stolee wrote:

Show 15 quoted lines

> On 6/1/2020 2:01 PM, Taylor Blau wrote:
> > Here's a short pair of patches that I wrote this morning after looking
> > at Stolee's most recent coverage report.
> >
> > The first patch is just cleanup, and the second patch is the real
> > change. It would have been nice to parameterize these tests over the
> > arguments to 'git commit graph' (ie., have three tests for 'write',
> > 'verify', and 'write --stdin-commits'), but '--stdin-commits' is special
> > since it requires input.
> >
> > These patches are based off the tip of 'next', but really only need my
> > changes from 'tb/commit-graph-no-check-oids'.
>
> The first patch is an obviously good patch, and it even has a good
> justification in the message.

Thanks.

> The second is also good. The case of forcing "--progress" would be
> enough for covering your new-ish progress meter. Perhaps the other
> tests (or at least the one specifying "--no-progress") could be
> removed, but I don't feel strongly about that.

Yeah, I don't feel strongly either. I figured that it would at least be more consistent with the surrounding tests to have the three variants. I guess we can see what others think, too.

> Thanks,
> -Stolee

Thanks, Taylor