Re: [PATCH] t: avoid alternation (not POSIX) in grep's BRE

From: Jeff King <peff@peff.net>
Date: May 28, 2020, 15:43 UTC
Message-ID: <20200528154349.GA1215380@coredump.intra.peff.net>
In-Reply-To: <xmqqo8q83x3v.fsf@gitster.c.googlers.com>

On Thu, May 28, 2020 at 08:20:04AM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> > [1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html#tag_09_03
> >
> > Fixes: f1e3df3169 (t: increase test coverage of signature verification
> >        output, 2020-03-04)
> 
> I do appreciate the information recorded in the log message, but not
> like this.  Does everybody's tool understand the "folding" the above
> two physical lines require to be able to handle it correctly?

If you use any of the Git tools, they support an "unfold" option like:

  git log --format='%(trailers:unfold)'

that normalizes this. However, I would not be at all surprised if people use custom readers. I think it may be a good policy to stick to the simplest machine-readable formats for trailers. Likewise I'd suggest using the full sha1-hex for future-proofing in this context.

-Peff