Re: jn/experimental-opts-into-proto-v2, was Re: What's cooking in git.git (May 2020, #09; Tue, 26)

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 27, 2020, 23:58 UTC
Message-ID: <20200527235808.GD56118@google.com>
In-Reply-To: <xmqq1rn5kpzi.fsf@gitster.c.googlers.com>

Hi,

Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> On Tue, 26 May 2020, Junio C Hamano wrote:

Show 14 quoted lines

>>> * jn/experimental-opts-into-proto-v2 (2020-05-21) 1 commit
>>>   (merged to 'next' on 2020-05-24 at 53cd664dfe)
>>>  + config: let feature.experimental imply protocol.version=2
>>>
>>>  "feature.experimental" configuration variable is to let volunteers
>>>  easily opt into a set of newer features, which use of the v2
>>>  transport protocol is now a part of.
>>>
>>>  Will cook in 'next'.
>>
>> Given that the `feature.experimental` option is supposed to increase
>> testing in the wild, sort of `next` but for users rather than developers
>> who build their own Git, could we maybe integrate this into v2.27.0,
>> still?

Yes, that was my hope when writing it.

> I have been wondering about the same thing, and if it were not using
> its own custom way to read the configuration, it would have been a
> non-brainer to merge it down before the release.

Hm, do you have more detail about this? git_config_get_bool feels very standard and non-custom.

Do you mean that you would like it to go in repo-settings.c?

>                                                   But this late in
> the cycle, I'd rather not.

Sure, I can understand.

Would this be something to put on "master" soon after the release?

Dscho, do you think it would be useful for downstreams such as Debian to apply it? (For Debian in particular, it's not hard to get "next" from experimental, so maybe not.)

Thanks, Jonathan