Re: [PATCH 1/1] Documentation: correct hash environment variable

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: May 25, 2020, 17:57 UTC
Message-ID: <20200525175758.GE1915090@camp.crustytoothpaste.net>
In-Reply-To: <CAN0heSoyxvTTaJaRmnQADTaMrWa4QBbGnXi8MUZp7ksibejc8g@mail.gmail.com>

On 2020-05-25 at 16:42:57, Martin Ågren wrote:

Show 11 quoted lines

> > -`GIT_DEFAULT_HASH_ALGORITHM`::
> > +`GIT_DEFAULT_HASH`::
> >         If this variable is set, the default hash algorithm for new
> >         repositories will be set to this value. This value is currently
> >         ignored when cloning; the setting of the remote repository
> 
> Indeed. This discrepancy is visible in the commit which added both the
> documentation and the implementation, 3c9331a129 ("builtin/init-db: add
> environment variable for new repo hash", 2020-02-22). As
> developers-only as this variable is, that commit was not in v2.26.0, so
> this might be worth fixing before cutting v2.27.0.

Yeah, thanks for catching this. I think this is worth fixing. It doesn't do anything right now except produce an error, but we might as well not mislead people.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204