git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] Improve Fix code coverage for checkout

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
May 21, 2020, 02:07 UTC
Message-ID
<20200521020712.1620993-1-sandals@crustytoothpaste.net>
In-Reply-To
<ef72aedf-4264-e386-9563-050c54483c93@gmail.com>

Patch #1 reduces the number of options in the scenario which Stolee mentioned above. There's now just a NULL and a non-NULL case, and the NULL case is now relatively straightforward and uninteresting.

Patch #2 adds a test for the particular set of options which will trigger this case as an independent test. I didn't think it made sense to put this in t0021, since ultimately that set of options isn't about conversions and it would seem out of place there, so I put it in t2060.

I'm ultimately on the fence for this case, because I think it's really a corner case and testing this is probably not that interesting, so my preference is for us to pick up patch 1 and drop patch 2. However, I added patch 2 in case we do indeed want a test for this, and I'll let Junio and others decide on what's best.

brian m. carlson (2):
  builtin/checkout: simplify metadata initialization
  t2060: add a test for switch with --orphan and --discard-changes
 builtin/checkout.c | 4 +---
 t/t2060-switch.sh  | 8 ++++++++
 2 files changed, 9 insertions(+), 3 deletions(-)
Previous: brian m. carlsonNext: brian m. carlson
Message 11 of 16 in “Git Test Coverage Report (v2.27.0-rc0)”
  1. Derrick StoleeMay 15, 2020
  2. Derrick StoleeMay 19, 2020
  3. René ScharfeMay 19, 2020
  4. brian m. carlsonMay 19, 2020
  5. brian m. carlsonMay 20, 2020
  6. t4067: make rename detection test output raw diffJonathan Tan, May 19, 2020
  7. Derrick StoleeMay 19, 2020
  8. 1/1 builtin/checkout: simplify metadata initializationbrian m. carlson, May 20, 2020
  9. Junio C HamanoMay 20, 2020
  10. brian m. carlsonMay 20, 2020
  11. 0/2 Improve Fix code coverage for checkoutbrian m. carlson, May 21, 2020
  12. 1/2 builtin/checkout: simplify metadata initializationbrian m. carlson, May 21, 2020
  13. Junio C HamanoMay 21, 2020
  14. brian m. carlsonMay 23, 2020
  15. 2/2 t2060: add a test for switch with --orphan and --discard-changesbrian m. carlson, May 21, 2020
  16. Derrick StoleeMay 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.