[PATCH 1/3] t4216: avoid unnecessary subshell in test_bloom_filters_not_used
- From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
- Date
- May 20, 2020, 03:44 UTC
- Message-ID
- <20200520034444.47932-2-carenas@gmail.com>
- In-Reply-To
- <20200520034444.47932-1-carenas@gmail.com>
Seems to trigger a bug in at least OpenBSD's 6.7 sh where it is interpreted as a history lookup and therefore fails 125-126, 128, 130.
Remove the subshell and get a space between ! and grep, so tests pass successfully.
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> --- t/t4216-log-bloom.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4216-log-bloom.sh b/t/t4216-log-bloom.sh index 21b68dd6c8..c855bcd3e7 100755 --- a/t/t4216-log-bloom.sh +++ b/t/t4216-log-bloom.sh @@ -70,7 +70,7 @@ test_bloom_filters_used () { test_bloom_filters_not_used () { log_args=$1 setup "$log_args" && - !(grep -q "statistics:{\"filter_not_present\":" "$TRASH_DIRECTORY/trace.perf") && + ! grep -q "statistics:{\"filter_not_present\":" "$TRASH_DIRECTORY/trace.perf" && test_cmp log_wo_bloom log_w_bloom }
-- 2.27.0.rc0.187.gede8c892b8