Re: [PATCH] ci/config: correct instruction for CI preferences
On Mon, May 18, 2020 at 09:52:34PM +0700, Đoàn Trần Công Danh wrote:
Show 24 quoted lines
> From e76eec3554 (ci: allow per-branch config for GitHub Actions,
> 2020-05-07), we started to allow contributors decide which branch
> they want to build with GitHub Actions
> by checking for a file named "ci/config/allow-ref".
>
> In order to assist those contributors,
> we provided a sample in "ci/config/allow-refs.sample",
> and instructed them to drop the ".sample",
> then commit that file to their repository.
>
> We've misspelt the filename in that change.
> Let's fix the spelling.
>
> While we're at it, also instruct our contributors introduce that new
> file to Git before commit, in case of they've never told Git before.
>
> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
> ---
>
> This is a merge from:
> <20200508180047.GD637136@coredump.intra.peff.net>
> <20200509012304.GB2111@danh.dev>
>
> It's slipped over the crack.
Yep, looks good. thanks for tying up this loose end.
> Hence, it may need Peff's SoB.
> Cc: Jeff King <peff@peff.net>
Signed-off-by: Jeff King <peff@peff.net>
-Peff
Jeff King <peff@peff.net>