[PATCH 1/2] help: add shell-path to --build-options
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- May 12, 2020, 23:42 UTC
- Message-ID
- <20200512234213.63651-2-emilyshaffer@google.com>
- In-Reply-To
- <20200512234213.63651-1-emilyshaffer@google.com>
It may be useful to know which shell Git was built to try to point to, in the event that shell-based Git commands are failing. $SHELL_PATH is set during the build and used to launch the manpage viewer, as well as by git-compat-util.h, and it's used during tests. 'git version --build-options' is encouraged for use in bug reports, so it makes sense to include this information there.
Signed-off-by: Emily Shaffer <emilyshaffer@google.com> --- help.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/help.c b/help.c index 1de9c0d589..44cee69c11 100644 --- a/help.c +++ b/help.c @@ -641,6 +641,7 @@ void get_version_info(struct strbuf *buf, int show_build_options) strbuf_addstr(buf, "no commit associated with this build\n"); strbuf_addf(buf, "sizeof-long: %d\n", (int)sizeof(long)); strbuf_addf(buf, "sizeof-size_t: %d\n", (int)sizeof(size_t)); + strbuf_addf(buf, "shell-path: %s\n", SHELL_PATH); /* NEEDSWORK: also save and output GIT-BUILD_OPTIONS? */ } }
-- 2.26.2.645.ge9eca65c58-goog