Re: [PATCH] Correctly initialize 'installed_handlers'
- From
Jeff King <peff@peff.net>
- Date
- May 8, 2020, 17:24 UTC
- Message-ID
- <20200508172445.GC637136@coredump.intra.peff.net>
- In-Reply-To
- <xmqqy2q2zbej.fsf@gitster.c.googlers.com>
On Fri, May 08, 2020 at 08:36:36AM -0700, Junio C Hamano wrote:
Show 31 quoted lines
> Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
>
> > the way this is handled would seem to indicate otherwise
> >
> > if (!installed_handlers) {
> > atexit(remove_tmp_objdir);
> > sigchain_push_common(remove_tmp_objdir_on_signal);
> > installed_handlers++;
> > }
>
> It is a curious piece of code.
>
> The "prepare a file-scope static and do something and increment it
> when it is 0" pattern expects the function to be called many times
> and do the guarded thing only once. However, there is this code:
>
> if (the_tmp_objdir)
> BUG(...);
>
> before we do anything else, and then before that "arrange to clean
> up, but do so just once" block, there is
>
> the_tmp_objdir = t;
>
> where t is the pointer to a "struct tmp_objdir" instance. So one
> part of the function expects to be called at most once, while
> another part is prepared to be called more than once.
>
> Almost all of this function is attributed to 2564d994 (tmp-objdir:
> introduce API for temporary object directories, 2016-10-03), so
> let's see if Peff remembers anything about this curiosity.There is "only once per program" and "only one at a time". When the tmp_objdir is destroyed (either directly or via tmp_objdir_migrate), we set the_tmp_objdir back to NULL, and you are free to then create another one.
In practice there's only one caller (receive-pack) and it only ever uses one tmp_objdir per program, so it's mostly academic. But tmp-objdir.c was written to be as reusable and least-surprising as possible. I would have avoided the "one at a time" rule if I could, but the semantics are unclear (if you have two active, which one should object-writes go to?).
The atexit and signal handlers could be removed when there's no tmp_objdir active, but there's no easy way to remove them (there's nothing portable at all for atexit, and for sigchain we don't know if somebody else has pushed in the meantime).
-Peff