Re: [PATCH v4] submodule: port subcommand 'set-url' from shell to C

From: Shourya Shukla <shouryashukla.oo@gmail.com>
Date: May 7, 2020, 04:40 UTC
Message-ID: <20200507044028.GA5168@konoha>
In-Reply-To: <xmqqwo5o6hzp.fsf@gitster.c.googlers.com>

On 06/05 11:22, Junio C Hamano wrote:

Show 6 quoted lines

> Ah, I misread those examples that suggested that you are supposed to
> check for N+1 when you expect N arguments.   They are *not* using
> parse_options() and that is where that funny numbering comes from.
> 
> This one uses "argc = parse_options(...)" so we should check for N
> when we want N args.  Thanks.

No worries. BTW, should I include the `path == NULL` check in the if-statement? I think the `argc` check would suffice but I would still love to hear a final verdict from you and Christian :)