Re: [PATCH] commit-graph: avoid memory leaks

From: Taylor Blau <me@ttaylorr.com>
Date: May 4, 2020, 22:15 UTC
Message-ID: <20200504221500.GG45250@syl.local>
In-Reply-To: <16be6de4-3453-2fc2-2881-7068bf674517@gmail.com>

On Mon, May 04, 2020 at 04:20:41PM -0400, Derrick Stolee wrote:

Show 18 quoted lines

> On 5/4/2020 3:13 PM, Jonathan Tan wrote:
> > A fuzzer running on the entry point provided by fuzz-commit-graph.c
> > revealed a memory leak when parse_commit_graph() creates a struct
> > bloom_filter_settings and then returns early due to error. Fix that
> > error by always freeing that struct first (if it exists) before
> > returning early due to error.
>
> This fuzzer is an excellent tool that I hope can continue to be
> extended to other features. Here is a case where it found an error in
> a feature long after the integration was introduced.
>
> > While making that change, I also noticed another possible memory leak -
> > when the BLOOMDATA chunk is provided but not BLOOMINDEXES. Also fix that
> > error.
>
> Thanks for discovering these issues, and for fixing them!
>
> Reviewed-by: Derrick Stolee <dstolee@microsoft.com>

Since it already appears to be queued, I'm not sure that my review is adding much. But, this fix looks very good to me, and I am grateful for you running a fuzzer against this code, and finding/fixing bugs in it.

  Reviewed-by: Taylor Blau <me@ttaylorr.com>

> Thanks,
> -Stolee

Thanks, Taylor