git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: proto v2 fixes for maint (was Re: Preparing for a Git 2.26.3 release)

From
Michal Suchánek <msuchanek@suse.de>
Date
Apr 28, 2020, 18:16 UTC
Message-ID
<20200428201657.30467979@naga.burning-in.hell>
In-Reply-To
<xmqq7dxz4j62.fsf@gitster.c.googlers.com>

On Tue, 28 Apr 2020 10:25:09 -0700 Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines
> Jonathan Nieder <jrnieder@gmail.com> writes:
> 
> > Since then we've heard about a few related (non-security) regressions.
> > I'd like to avoid giving people an excuse not to upgrade, so this
> > morning[1] I promised a discussion of what I'd like to see in a 2.26.3
> > release to help with that.  
> 
> Thanks for starting this.  
> 
> I'll have chances to comment on other areas you listed, but since
> I've answered on v2-proto stuff to somebody else already...
> 
> > The protocol version change was painful for users that fetch in the
> > same repo from linux-next and other linux remotes[5].  The problem has
> > been isolated and fixed, so we could either apply the revert or apply
> > the fixes[6].  
> 
> The demote patch hasn't even hit 'master'.  
> 
> My preference is to merge the demotion down to 'master' and 'maint'
> while merging down this fix to 'next' and to 'master'.

I understand that this issue puts v2 protocol into question and you want to go back to v0 as default. Why not merge the fixes for v2, though? Even if it is not the default keeping it broken in maint does not sound great.

Thanks
Michal
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 9 in “Preparing for a Git 2.26.3 release”
  1. Jonathan NiederApr 28, 2020
  2. Elijah NewrenApr 28, 2020
  3. proto v2 fixes for maint (was Re: Preparing for a Git 2.26.3 release)Junio C Hamano, Apr 28, 2020
  4. Michal SuchánekApr 28, 2020
  5. Junio C HamanoApr 28, 2020
  6. Jonathan NiederApr 29, 2020
  7. Junio C HamanoMay 8, 2020
  8. Johannes SchindelinMay 9, 2020
  9. Junio C HamanoMay 9, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.