Re: [PATCH] Revert "fetch: default to protocol version 2"

From: Jeff King <peff@peff.net>
Date: Apr 22, 2020, 19:47 UTC
Message-ID: <20200422194733.GA561178@coredump.intra.peff.net>
In-Reply-To: <20200422194047.GD558336@coredump.intra.peff.net>

On Wed, Apr 22, 2020 at 03:40:47PM -0400, Jeff King wrote:

Show 8 quoted lines

> > By the way, I'd recommend the immediate workaround of
> > 
> > 	git fetch --negotiation-tip=refs/remotes/xo/* xo
> > 
> > instead.  But that's a separate subject.
> 
> It seems like if we are fetching with refspec X/*:Y/* that we should
> perhaps automatically select our local Y/* negotiation tips.

Actually, I guess that option is not "please prioritize these tips", but rather "use only these tips". So using it can sometimes hurt.

Show 6 quoted lines

> That said, neither it (nor the manual version above) would help the case
> I've been testing with. It's a first fetch from "xo", which can reuse
> history we already have from other remotes.
> 
> I agree it's a good workaround for folks doing their daily fetches,
> though.

I did confirm that re-running my test with --negotiation-tip=master (to point to Linus's tree, avoiding the clogging of "next" commits) results in the usual good pack in a reasonable time.

-Peff