Re: Bug in 2.26: git-fetch fetching too many objects?

From: Jeff King <peff@peff.net>
Date: Apr 21, 2020, 21:11 UTC
Message-ID: <20200421211133.GB3510074@coredump.intra.peff.net>
In-Reply-To: <20200421193611.GA103469@google.com>

On Tue, Apr 21, 2020 at 12:36:11PM -0700, Jonathan Nieder wrote:

Show 9 quoted lines

> > This is at least the fourth time we hear that v2 may not be ready
> > for the real-world use.  Perhaps we should revert the default flip
> > on the maintenance track while we hunt for bugs and improve the
> > protocol support?
> 
> That feels to me like an overreaction, since these are all reports of
> the same issue that we have a fix to.  Shouldn't we just flip the
> default for fetch.negotiationAlgorithm to skipping?  If we revert to
> buy time, what would we do with that time?

Do we know that fetch.negotiationAlgorithm helps? I thought we didn't yet know the actual cause of the bug. If that is the culprit, and people would have seen this under v0 using stateless-http, why didn't we get more reports of it then? Surely some people used http over git://?

I do agree that flipping the default away from v2 may be premature, especially if we don't have a plan for moving forward. It sounds like swapping out the negotiationAlgorithm would at least be likely to generate more data, even if it is only a guess.

-Peff