Re: Possible regression in git 2.26.0

From: Jeff King <peff@peff.net>
Date: Apr 10, 2020, 21:00 UTC
Message-ID: <20200410210044.GA2074620@coredump.intra.peff.net>
In-Reply-To: <20200331172218.evsoljccfmjec2mz@chatter.i7.local>

On Tue, Mar 31, 2020 at 01:22:18PM -0400, Konstantin Ryabitsev wrote:

Show 12 quoted lines

> 16:47 <sfr> repo: git://anongit.freedesktop.org/drm/drm-misc branch: for-linux-next
> 16:48 <sfr> went from trying to transfer 7226542 to just 19
> 16:48 <sfr> even after I did a reset of the remote branch at my end and a gc
> 16:49 <sfr> it updated b1e7396a1d0e..98878d9dfc7a
> 16:50 <sfr> in case it matters, I have "tagopt = --no-tags" set for all the repos
>             I fetch (for obvious reasons)
> 16:52 <sfr> removing the protocol.version=1 (and resetting/gcing) gets me the bad 
>             behaviour again :-(
> 16:52 <sfr> mricon: so good shot! :-)
> 
> It appears that there are cases where protocol.version=2 is causing 
> weird results during ref negotiation?

Possibly. The underlying negotiation technique is roughly the same, but it's possible there's a subtle difference in the v2 code.

I spent a little time trying to reproduce with the branch mentioned above, but couldn't. If somebody hits it again, the most useful thing would be:

  - a dump of "git for-each-ref" in the client repo

  - the exact fetch (or pull) command which behaves differently between
    the two protocols

-Peff