Re: [PATCH] pack-format: document missing fields

From: Danh Doan <congdanhqx@gmail.com>
Date: Apr 10, 2020, 01:19 UTC
Message-ID: <20200410011925.GB2462@danh.dev>
In-Reply-To: <xmqqlfn4mjm3.fsf@gitster.c.googlers.com>

On 2020-04-09 14:31:32-0700, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> "Alba Mendez via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> >       4-byte version number (network byte order):
> > -	 Git currently accepts version number 2 or 3 but
> > +         Git currently accepts version number 2 or 3 but
> >           generates version 2 only.
> 
> Hmph, what is this hunk about?

The original line is "<TAB><SPACE>Git", she changed to 9 <SPACE> to match with other lines. I guess she set tabstop=4, this paragraph will be mis-aligned on that.

Show 9 quoted lines

> > -     (undeltified representation)
> > -     n-byte type and length (3-bit type, (n-1)*7+4-bit length)
> > -     compressed data
> > -
> > -     (deltified representation)
> > -     n-byte type and length (3-bit type, (n-1)*7+4-bit length)
> > -     20-byte base object name if OBJ_REF_DELTA or a negative relative
> > -	 offset from the delta object's position in the pack if this
> > -	 is an OBJ_OFS_DELTA object

Alba, if you gonna change the above <TAB> to 8 <SPACE> above, you may want to change here, too. This paragraph was written with tabstop=4 in mind. And it's in the context of below hunk.

I'm not sure if changing <TAB> to 8 <SPACE> was expected in this file because <TAB> and <SPACE> is also mixed in "Pack file entry" section.

-- 
Danh