git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bloom: ignore renames when computing changed paths

From
Jeff King <peff@peff.net>
Date
Apr 9, 2020, 14:15 UTC
Message-ID
<20200409141559.GD3494212@coredump.intra.peff.net>
In-Reply-To
<e3ace6a6-eb2e-0544-c9fa-eaed6e9d6c6f@gmail.com>
On Thu, Apr 09, 2020 at 10:00:46AM -0400, Derrick Stolee wrote:
Show 13 quoted lines
> >> So our issue was really that the partial clone prefetch logic was just
> >> overly aggressive.
> > 
> > Right, but I'm not sure how this patch could ever have helped, since
> > it's just setting a variable to the value it _should_ have already had.
> > 
> > Or do you just mean that the issue would have gone away with Jonathan's
> > patch to make the prefetching less aggressive?
> 
> Yes, with Jonathan's patch we stop downloading blobs during Bloom filter
> computations. The patch this is "replacing" disabled that download in a
> different way, depending only on if detect_renames is false and the diff
> output doesn't need file contents. (Jonathan's is better.)

OK. I'm willing to leave it there, but I'm still puzzled as to why the original patch would have done anything based on detect_renames, which would always be false.

-Peff
Previous: Derrick StoleeNext: Derrick Stolee via GitGitGadget
Message 8 of 9 in “bloom: ignore renames when computing changed paths”
  1. bloom: ignore renames when computing changed pathsDerrick Stolee via GitGitGadget, Apr 8, 2020
  2. Junio C HamanoApr 8, 2020
  3. Philip OakleyApr 8, 2020
  4. Jeff KingApr 8, 2020
  5. Derrick StoleeApr 9, 2020
  6. Jeff KingApr 9, 2020
  7. Derrick StoleeApr 9, 2020
  8. Jeff KingApr 9, 2020
  9. bloom: ignore renames when computing changed pathsDerrick Stolee via GitGitGadget, Apr 9, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.