Re: [PATCH 2/2] pull doc: correct outdated description of an example
- From
Jeff King <peff@peff.net>
- Date
- Apr 6, 2020, 20:22 UTC
- Message-ID
- <20200406202236.GB1245278@coredump.intra.peff.net>
- In-Reply-To
- <46365925d22d31feae7618614dd7872a19bebeef.1586101819.git.gitgitgadget@gmail.com>
On Sun, Apr 05, 2020 at 03:50:19PM +0000, Philippe Blain via GitGitGadget wrote:
Show 10 quoted lines
> From: Philippe Blain <levraiphilippeblain@gmail.com> > > Since f269048754 (fetch: opportunistically update tracking refs, > 2013-05-11), the underlying `git fetch` in `git pull <remote> <branch>` > updates the configured remote-tracking branch for <branch>. > > However, an example in the 'Examples' section of the `git pull` > documentation still states that this is not the case. > > Correct the description of this example.
Yeah, I think the example just never got updated. Your patch looks good.
Another option would be to use a direct URL rather than a configured remote, which really would just update FETCH_HEAD. But I don't think the handling of remote-tracking branches is central to this example either way, so your minimal change is better.
-Peff