git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Inefficiency of partial shallow clone vs shallow clone + "old-style" sparse checkout

From
Jeff King <peff@peff.net>
Date
Apr 1, 2020, 12:18 UTC
Message-ID
<20200401121846.GB1916590@coredump.intra.peff.net>
In-Reply-To
<20200331214653.GA95875@syl.local>
On Tue, Mar 31, 2020 at 03:46:53PM -0600, Taylor Blau wrote:
> On Sat, Mar 28, 2020 at 12:58:41PM -0400, Derrick Stolee wrote:
>
> > This is a good find, and I expect we will find more "opportunities"
> > to insert OBJECT_INFO_SKIP_FETCH_OBJECT like this.

The worst part is that we _did_ find this in git-fetch, and fixed it in 3e96c66805 (partial-clone: avoid fetching when looking for objects, 2020-02-21). But as usual git-clone has its own kind-of-the-same implementation of the same feature.

> Should we turn this into a proper patch and have it reviewed? It seems
> to be helping the situation, and after thinking about it (only briefly,
> but more than not ;-)), this seems like the right direction.

Yes, I wanted to simplify the test and double-check the addition of QUICK. See the patch I just posted in:

  https://lore.kernel.org/git/20200401121537.GA1916590@coredump.intra.peff.net/
-Peff
Previous: Taylor BlauNext: Konstantin Tokarev
Message 5 of 13 in “Inefficiency of partial shallow clone vs shallow clone + "old-style" sparse checkout”
  1. Konstantin TokarevMar 27, 2020
  2. Jeff KingMar 28, 2020
  3. Derrick StoleeMar 28, 2020
  4. Taylor BlauMar 31, 2020
  5. Jeff KingApr 1, 2020
  6. Konstantin TokarevMar 31, 2020
  7. Konstantin TokarevMar 31, 2020
  8. Derrick StoleeApr 1, 2020
  9. Konstantin TokarevApr 1, 2020
  10. Jeff KingApr 1, 2020
  11. clone: use "quick" lookup while following tagsJeff King, Apr 1, 2020
  12. Konstantin TokarevApr 1, 2020
  13. Jeff KingApr 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.