Re: [PATCH v4] builtin/commit-graph.c: support '--input=graphed'
- From
Jeff King <peff@peff.net>
- Date
- Mar 27, 2020, 09:13 UTC
- Message-ID
- <20200327091336.GC610157@coredump.intra.peff.net>
- In-Reply-To
- <e0f42a2f3c0162a5d43bb2bce0f69264b59f92e9.1584994172.git.me@ttaylorr.com>
On Mon, Mar 23, 2020 at 02:12:19PM -0600, Taylor Blau wrote:
Show 10 quoted lines
> Hi, > > In response to some discussion in [1], here is another idea instead of > '--input=none' that may make things a little clearer. Since it had been > a long time, I reminded myself that '--input=none' means > "--input=append, but don't look at packs as is usually the default". > > In [1], Gabor suggested that we could call this '--input=exists' or > '--input=existing', but I think that 'graphed' may be clearer, since > it is closer to "only _graphed_ commits".
Yeah, this name is much more clear to me than "none" (and would have prevented some mild confusion I had when experimenting the other day).
> Another option would be to call this '--input=only-graphed', but I think > that may be overly verbose for what we're going for here.
Agreed.
-Peff