git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] t/lib-credential.sh: drop shebang line

From
Jeff King <peff@peff.net>
Date
Mar 26, 2020, 08:25 UTC
Message-ID
<20200326082527.GA3611762@coredump.intra.peff.net>
In-Reply-To
<20200326082338.GA3611364@coredump.intra.peff.net>

The purpose of lib-credential.sh is to be sourced into other test scripts. It doesn't need a "#!/bin/sh" line, as running it directly makes no sense. Nor does it serve any real filetype documentation purpose, as the file is cleary named with a ".sh" extension.

In the spirit of c74c72034f (test: replace shebangs with descriptions in shell libraries, 2013-11-25), let's replace it with a human-readable description.

Signed-off-by: Jeff King <peff@peff.net>
---
I left the similar case in lib-gpg alone so as not to conflict with
Dscho's version.
 t/lib-credential.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/lib-credential.sh b/t/lib-credential.sh
index 937b831ea6..5ea8bc9f1d 100755
--- a/t/lib-credential.sh
+++ b/t/lib-credential.sh
@@ -1,4 +1,5 @@
-#!/bin/sh
+# Shell library for testing credential handling including helpers. See t0302
+# for an example of testing a specific helper.
 
 # Try a set of credential helpers; the expected stdin,
 # stdout and stderr should be provided on stdin,
-- 
2.26.0.576.gb87790c3c1
Previous: Jeff KingNext: Denton Liu
Message 2 of 4 in “test shell-library cleanups”
  1. 0/2 test shell-library cleanupsJeff King, Mar 26, 2020
  2. 1/2 t/lib-credential.sh: drop shebang lineJeff King, Mar 26, 2020
  3. Denton LiuMar 26, 2020
  4. 2/2 t/lib-*.sh: drop executable bitJeff King, Mar 26, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.