Re: [PATCH] t3419: drop EXPENSIVE tests
- From
Jeff King <peff@peff.net>
- Date
- Mar 22, 2020, 19:19 UTC
- Message-ID
- <20200322191950.GB671552@coredump.intra.peff.net>
- In-Reply-To
- <20200322171111.GB6499@camp.crustytoothpaste.net>
On Sun, Mar 22, 2020 at 05:11:11PM +0000, brian m. carlson wrote:
Show 9 quoted lines
> > Let's simplify the script by dropping the EXPENSIVE run. That in turn > > lets us drop the do_tests() wrapper, which lets us consistently use > > single-quotes for our test snippets. And we can drop the useless > > test_debug() timings, as well as their run() helper. And finally, while > > we're here, we can replace the count() helper with the standard > > test_seq(). > > I'm also fine with this solution. As long as this test doesn't fail > with EXPENSIVE, I'm happy.
Just to be clear, this is meant to go on top of your fix, which is already in next, so I think that part is fixed either way. :)
-Peff