git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/1] submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'

From
Shourya Shukla <shouryashukla.oo@gmail.com>
Date
Mar 18, 2020, 14:20 UTC
Message-ID
<20200318142024.16681-1-shouryashukla.oo@gmail.com>
In-Reply-To
<20200318095842.27679-1-shouryashukla.oo@gmail.com>

Subcommands in 'submodule--helper.c' which give a callback to other functions have structures and macros named in the format: 'subcommand_cb' and 'SUBCOMMAND_CB_INIT' respectively.

The subcommand 'foreach' did not follow this convention and therefore had the naming of the form: 'struct foreach_cb' and 'CB_FOREACH_INIT'. Rename these to: 'struct foreach_cb' and 'FOREACH_CB_INIT' respectively.

Changes in v2:
	Reworded the commit message. The last statement was wrong.
	Changed it from: 
	"Rename the aforementioned structures and macros:
	'struct foreach_cb' to 'struct cb_foreach' and 'CB_FOREACH_INIT'
	to 'FOREACH_CB_INIT'."
	;to:
	"Rename the aforementioned structures and macros:
	'struct cb_foreach' to 'struct foreach_cb' and 'CB_FOREACH_INIT'
	to 'FOREACH_CB_INIT'."
Shourya Shukla (1):
  submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'
 builtin/submodule--helper.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
-- 
2.20.1
Previous: Derrick StoleeNext: Shourya Shukla
Message 4 of 5 in “submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'”
  1. 0/1 submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'Shourya Shukla, Mar 18, 2020
  2. 1/1 submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'Shourya Shukla, Mar 18, 2020
  3. Derrick StoleeMar 18, 2020
  4. 0/1 submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'Shourya Shukla, Mar 18, 2020
  5. 1/1 submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'Shourya Shukla, Mar 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.