Re: Regression in v2.26.0-rc0 and Magit

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 12, 2020, 23:35 UTC
Message-ID: <20200312233504.GH120942@google.com>
In-Reply-To: <3091652.KAqcNXvZJ4@cayenne>

Hi,

Jean-Noël AVILA wrote:

Show 9 quoted lines

> When trying the latest rc with magit, I found that git segfaults
> under Magit with auto-revert enabled. The message in emacs is
>
> Error in post-command-hook (magit-auto-revert-mode-check-buffers):
> (wrong-type-argument number-or-marker-p "Segmentation Fault")
>
> I was able to bisect the issue to commit
> e0020b2f82910f50bc697d86aff70c3796fbdc41 but unfortunately, it seems
> difficult to print the exact command from magit.

Thanks for reporting.  This is fixed by

 commit e6c57b49eb63e77ccf72215229744c4beaf04204 (es/outside-repo-errmsg-hints)
 Author: Emily Shaffer <emilyshaffer@google.com>
 Date:   Mon Mar 2 20:05:06 2020 -0800

    prefix_path: show gitdir if worktree unavailable

Junio, can you fast-track that fix to "master"? Emily, can you add a test?

Thanks, Jonathan