Re: [Question] Is extensions.partialClone defunct?

From: Jonathan Tan <jonathantanmy@google.com>
Date: Mar 12, 2020, 17:07 UTC
Message-ID: <20200312170714.180996-1-jonathantanmy@google.com>
In-Reply-To: <5981c317-4b39-de15-810b-a781aa79189d@gmail.com>

> I was looking into an issue around partial clone in v2.26.0-rc1, but found several references in the code and documentation to "extensions.partialClone".

[snip]

> but it appears that we rely on the "remote.<name>.promisor = true" setting instead of this extension.

Hmm...besides giving the name of the promisor remote, the extensions.partialClone setting is there to prevent old versions of Git (that do not know this extension) from manipulating the repo.

Show 17 quoted lines

> Indeed, if we run `git clone --filter=blob:none <url>" the resulting .git/config file is as follows:
> 
> [core]
>         repositoryformatversion = 1
>         filemode = false
>         bare = false
>         logallrefupdates = true
>         symlinks = false
>         ignorecase = true
> [remote "origin"]
>         url = <url>
>         fetch = +refs/heads/*:refs/remotes/origin/*
>         promisor = true
>         partialclonefilter = blob:none
> [branch "master"]
>         remote = origin
>         merge = refs/heads/master

I cloned and indeed it is as Stolee describes. Git still works as expected if I remove "promisor = true" and add "[extensions]\npartialclone=origin", so at least extensions.partialClone is still supported, even if not written by default.

> So, I thought I would put this up on the list to point out the inconsistency, in case someone with more context has thoughts on the correct way forward here.

Thanks for bringing this up.