git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: fix error popup when doing blame -> "Show History Context"

From
BPBenjamin Poirier <benjamin.poirier@gmail.com>
Date
Mar 3, 2020, 00:10 UTC
Message-ID
<20200303001033.GA138670@f3>
In-Reply-To
<20200302183538.7195-1-me@yadavpratyush.com>
On 2020/03/03 00:05 +0530, Pratyush Yadav wrote:
Show 17 quoted lines
> In d9c6469 (git-gui: update status bar to track operations, 2019-12-01)
> the call to 'ui_status' in 'do_gitk' was updated to create the newly
> introduced "status bar operation". This allowed this status text so show
> along with other operations happening in parallel, and removed a race
> between all these operations.
> 
> But in that refactor, the fact that 'ui_status' checks for the existence
> of 'main_status' was overlooked. This leads to an error message popping
> up when the user selects "Show History Context" from the blame window
> context menu on a source line. The error occurs because when running
> "blame" 'main_status' is not initialized.
> 
> So, add a check for the existence of 'main_status' in 'do_gitk'. This
> fix reverts to the original behaviour. In the future, we might want to
> look into a better way of telling 'do_gitk' which status bar to use.
> 
> Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
Tested-by: Benjamin Poirier <benjamin.poirier@gmail.com>
Thank you for looking into this.
Previous: Pratyush Yadav
Message 2 of 2 in “git-gui: fix error popup when doing blame -> "Show History Context"”
  1. git-gui: fix error popup when doing blame -> "Show History Context"Pratyush Yadav, Mar 2, 2020
  2. Benjamin PoirierMar 3, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.