Re: [PATCH] show_one_mergetag: print non-parent in hex form.
On 2020-02-29 at 13:07:57, Harald van Dijk via GitGitGadget wrote:
Show 5 quoted lines
> From: Harald van Dijk <harald@gigawatt.nl>
>
> When a mergetag names a non-parent, which can occur after a shallow
> clone, its hash was previously printed as raw data. Print it in hex form
> instead.
Show 18 quoted lines
> +test_expect_success GPG 'log --graph --show-signature for merged tag in shallow clone' '
> + test_when_finished "git reset --hard && git checkout master" &&
> + git checkout -b plain-shallow master &&
> + echo aaa >bar &&
> + git add bar &&
> + git commit -m bar_commit &&
> + git checkout --detach master &&
> + echo bbb >baz &&
> + git add baz &&
> + git commit -m baz_commit &&
> + git tag -s -m signed_tag_msg signed_tag_shallow &&
> + hash=$(git rev-parse HEAD) &&
> + git checkout plain-shallow &&
> + git merge --no-ff -m msg signed_tag_shallow &&
> + git clone --depth 1 --no-local . shallow &&
> + test_when_finished "rm -rf shallow" &&
> + git -C shallow log --graph --show-signature -n1 plain-shallow >actual &&
> + grep "tag signed_tag_shallow names a non-parent $hash" actual
I appreciate you computing this value with git rev-parse.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204