Re: [PATCH 1/1] ls-remote: don't use '-h' for options
- From
Danh Doan <congdanhqx@gmail.com>
- Date
- Feb 27, 2020, 13:08 UTC
- Message-ID
- <20200227130833.GA10339@danh.dev>
- In-Reply-To
- <b0397b3285eab3448a3fd5dd2c50abb9@pascalroeleven.nl>
On 2020-02-27 12:42:18+0100, dev@pascalroeleven.nl wrote:
> The '-h' option for ls-remote will never be reached as the argument is > already processed by the git wrapper before passed on to ls-remote. > The ls-remote help text will therefore be displayed instead of the > '--heads' option.
No, git ls-remote still see '-h'
- 'git ls-remote -h' will show short help. - 'git ls-remote -h <remote>' and 'git ls-remote --heads <remote>' will show the same output
See also: https://lore.kernel.org/git/xmqqk1ztmkbn.fsf@gitster.mtv.corp.google.com/
xmqqk1ztmkbn.fsf@gitster.mtv.corp.google.com
Show 37 quoted lines
>
> Signed-off-by: Pascal Roeleven <dev@pascalroeleven.nl>
> ---
> Documentation/git-ls-remote.txt | 1 -
> builtin/ls-remote.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/git-ls-remote.txt
> b/Documentation/git-ls-remote.txt
> index a2ea1fd..b5b7d7a 100644
> --- a/Documentation/git-ls-remote.txt
> +++ b/Documentation/git-ls-remote.txt
> @@ -21,7 +21,6 @@ commit IDs.
>
> OPTIONS
> -------
> --h::
> --heads::
> -t::
> --tags::
> diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c
> index 6ef5195..85ce336 100644
> --- a/builtin/ls-remote.c
> +++ b/builtin/ls-remote.c
> @@ -63,7 +63,7 @@ int cmd_ls_remote(int argc, const char **argv, const char
> *prefix)
> N_("path of git-upload-pack on the remote host"),
> PARSE_OPT_HIDDEN },
> OPT_BIT('t', "tags", &flags, N_("limit to tags"), REF_TAGS),
> - OPT_BIT('h', "heads", &flags, N_("limit to heads"), REF_HEADS),
> + OPT_BIT(0, "heads", &flags, N_("limit to heads"), REF_HEADS),
> OPT_BIT(0, "refs", &flags, N_("do not show peeled tags"), REF_NORMAL),
> OPT_BOOL(0, "get-url", &get_url,
> N_("take url.<base>.insteadOf into account")),
> --
> 2.20.1
> -- Danh