git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] worktree: drop unused code from get_main_worktree()

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Feb 24, 2020, 01:59 UTC
Message-ID
<20200224015935.19190-1-sunshine@sunshineco.com>

This code has been unused since fa099d2322 (worktree.c: kill parse_ref() in favor of refs_resolve_ref_unsafe(), 2017-04-24), so drop it.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
Just something I noticed while reviewing a patch[1] on the mailing list.
[1]: https://lore.kernel.org/git/8718facbc951614f19407afa6ca8d6110507483d.1582484231.git.gitgitgadget@gmail.com/
 worktree.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/worktree.c b/worktree.c
index 5b4793caa3..33c2655534 100644
--- a/worktree.c
+++ b/worktree.c
@@ -47,15 +47,12 @@ static void add_head_info(struct worktree *wt)
 static struct worktree *get_main_worktree(void)
 {
 	struct worktree *worktree = NULL;
-	struct strbuf path = STRBUF_INIT;
 	struct strbuf worktree_path = STRBUF_INIT;
 
 	strbuf_add_absolute_path(&worktree_path, get_git_common_dir());
 	if (!strbuf_strip_suffix(&worktree_path, "/.git"))
 		strbuf_strip_suffix(&worktree_path, "/.");
 
-	strbuf_addf(&path, "%s/HEAD", get_git_common_dir());
-
 	worktree = xcalloc(1, sizeof(*worktree));
 	worktree->path = strbuf_detach(&worktree_path, NULL);
 	/*
@@ -69,7 +66,6 @@ static struct worktree *get_main_worktree(void)
 		is_bare_repository();
 	add_head_info(worktree);
 
-	strbuf_release(&path);
 	strbuf_release(&worktree_path);
 	return worktree;
 }
-- 
2.25.1.526.gf05a752211
Next: Jeff King
Message 1 of 3 in “worktree: drop unused code from get_main_worktree()”
  1. worktree: drop unused code from get_main_worktree()Eric Sunshine, Feb 24, 2020
  2. Jeff KingFeb 24, 2020
  3. Junio C HamanoFeb 24, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.