git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/5] Wildcard matching for credentials

From
Jeff King <peff@peff.net>
Date
Feb 21, 2020, 06:10 UTC
Message-ID
<20200221061007.GG1280313@coredump.intra.peff.net>
In-Reply-To
<20200220022413.258026-1-sandals@crustytoothpaste.net>
On Thu, Feb 20, 2020 at 02:24:08AM +0000, brian m. carlson wrote:
Show 12 quoted lines
> This series introduces wildcard matching (that is, urlmatch support) for
> credential config options, just like for the http options.  This is
> helpful in corporate environments where custom credentials should be
> used across a wide variety of subdomains.
> 
> Changes from v1:
> * Add a variety of additional tests in patch 3.
> * Switch to using the last matching config option for
>   credential.username like we do everywhere else.
> * Use all matching config keys, as we did before.
> * Skip calling git_default_config.
> * Fix percent-encoding handling and add a function to handle that.

Thanks, this addresses all of my concerns, and I'm really happy to see all the new tests covering various bits from our discussion. Really cleanly done.

-Peff
Previous: Junio C Hamano
Message 8 of 8 in “Wildcard matching for credentials”
  1. 0/5 Wildcard matching for credentialsbrian m. carlson, Feb 20, 2020
  2. 1/5 mailmap: add an additional email address for brian m. carlsonbrian m. carlson, Feb 20, 2020
  3. 2/5 t1300: add test for urlmatch with multiple wildcardsbrian m. carlson, Feb 20, 2020
  4. 4/5 credential: use the last matching username in the configbrian m. carlson, Feb 20, 2020
  5. 3/5 t0300: add tests for some additional casesbrian m. carlson, Feb 20, 2020
  6. 5/5 credential: allow wildcard patterns when matching configbrian m. carlson, Feb 20, 2020
  7. Junio C HamanoFeb 20, 2020
  8. Jeff KingFeb 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.