git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-gui: add missing close bracket

From
Pratyush Yadav <me@yadavpratyush.com>
Date
Feb 17, 2020, 16:10 UTC
Message-ID
<20200217161056.10864-1-me@yadavpratyush.com>

In d9c6469 (git-gui: update status bar to track operations, 2019-12-01), the status bar was refactored to allow multiple overlapping operations.

Since the refactor changed the status bar interface, all callsites had to be refactored to use the new interface. During that refactoring, this closing bracket was missed. This leads to an error message popping up when doing 'Branch->Reset...'.

Signed-off-by: Pratyush Yadav <me@yadavpratyush.com>
---
Reported at https://github.com/prati0100/git-gui/issues/28
 lib/merge.tcl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/merge.tcl b/lib/merge.tcl
index 8df8ffa..664803c 100644
--- a/lib/merge.tcl
+++ b/lib/merge.tcl
@@ -244,7 +244,7 @@ Continue with resetting the current changes?"]
 		set status_bar_operation [$::main_status \
 			start \
 			[mc "Aborting"] \
-			[mc "files reset"]
+			[mc "files reset"]]
 		fileevent $fd readable [namespace code [list \
 			_reset_wait $fd $status_bar_operation]]
 	} else {
--
2.21.1
Next: Pratyush Yadav
Message 1 of 2 in “git-gui: add missing close bracket”
  1. git-gui: add missing close bracketPratyush Yadav, Feb 17, 2020
  2. Pratyush YadavFeb 18, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.