[PATCH 2/3] t1300: add test for urlmatch with multiple wildcards
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Feb 14, 2020, 22:59 UTC
- Message-ID
- <20200214225929.541306-3-sandals@crustytoothpaste.net>
- In-Reply-To
- <20200214225929.541306-1-sandals@crustytoothpaste.net>
From: brian m. carlson <bk2204@github.com>
Our urlmatch code handles multiple wildcards, but we don't currently have a test that checks this code path. Add a test that we handle this case correctly to avoid any regressions.
Signed-off-by: brian m. carlson <bk2204@github.com> --- t/t1300-config.sh | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/t/t1300-config.sh b/t/t1300-config.sh index 983a0a1583..8b0cac80a3 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -1408,6 +1408,8 @@ test_expect_success 'urlmatch favors more specific URLs' ' cookieFile = /tmp/wildcard.txt [http "https://*.example.com/wildcardwithsubdomain"] cookieFile = /tmp/wildcardwithsubdomain.txt + [http "https://*.example.*"] + cookieFile = /tmp/multiwildcard.txt [http "https://trailing.example.com"] cookieFile = /tmp/trailing.txt [http "https://user@*.example.com/"] @@ -1454,6 +1456,10 @@ test_expect_success 'urlmatch favors more specific URLs' ' echo http.cookiefile /tmp/sub.txt >expect && git config --get-urlmatch HTTP https://user@sub.example.com >actual && + test_cmp expect actual && + + echo http.cookiefile /tmp/multiwildcard.txt >expect && + git config --get-urlmatch HTTP https://wildcard.example.org >actual && test_cmp expect actual '