Re: [PATCH v2 0/5] commit-graph: use 'struct object_directory *' everywhere
On Mon, Feb 03, 2020 at 01:17:53PM -0800, Taylor Blau wrote:
Show 13 quoted lines
> Here is a re-roll of the series in this thread to replace string-based
> path comparison in 'commit-graph.c' code with raw pointer comparison of
> 'struct object_directory *'s.
>
> The only thing that has changed substantially since v1 is that I swapped
> the order of patches 2/6 and 4/6. What was patch 3/6 got folded into
> what is now patch 2/5. This resolves an inconvenience where we had to
> define a helper function in 'commit-graph.c', when it really belonged in
> 'builtin/commit-graph.c'.
>
> I took a few other suggestions from Martin in what is now patch 4/5, and
> noticed a few other small things along the way. A range-diff since v1 is
> included below.
Thanks, I read over this and the new layout looks quite good.
-Peff