Re: [PATCH 0/7] fix inconsistent uses of the_repo in parse_object()'s call chain

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jan 30, 2020, 23:46 UTC
Message-ID: <20200130234651.GO4113372@camp.crustytoothpaste.net>
In-Reply-To: <xmqqmua4bpqt.fsf@gitster-ct.c.googlers.com>

On 2020-01-30 at 21:26:02, Junio C Hamano wrote:

Show 12 quoted lines

> Matheus Tavares <matheus.bernardino@usp.br> writes:
> 
> > Note: I also tried to replace some uses of the_hash_algo with the struct
> > git_hash_algo from the received repository, for consitency. (In
> > practice, I'm not sure if this is very useful right now, but maybe it
> > will be relevant for the change to SHA256?) Still, many functions in
> > parse_object()'s call chain call oid_to_hex(), which uses the_hash_algo.
> > Since changing this would require a much bigger operation, I decided to
> > leave it as is, for now.
> 
> Passing a repo instance throughout the callchain and redusing the
> use of the_repo would be a worthwhile longer term clean-up.

Yes, I think this would be a nice change to see.

> Moving off of the_hash_algo to repo->hash_algo is, too, and it is
> very much relevant to the "newhash" work Brian (CCed) has been
> working on.  You two do not want to step on each other's toes.
> Please coordinate.

This series is fine from my end. I think it provides a nice improvement that I can take advantage of in the future, so I don't see a reason to hold it up on my account. The few patches I have in this area would be easy to rebase or adjust.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204