Re: packObjectsHook and the git executable

From: Jeff King <peff@peff.net>
Date: Jan 30, 2020, 08:23 UTC
Message-ID: <20200130082353.GA3442119@coredump.intra.peff.net>
In-Reply-To: <CAGyf7-HkUV43A79DKiDVvKnW5vuwsFz0KnZKj9bBQYc906VONg@mail.gmail.com>

On Wed, Jan 29, 2020 at 11:38:23PM -0800, Bryan Turner wrote:

Show 13 quoted lines

> I suspect it's a case of a broken Git build. Not that Git is doing
> anything wrong, or has any problems with its build, to be clear--I
> mean instead that someone ran a local build and didn't set it up
> "right". Correct me if I'm wrong but:
> - If the GIT_EXEC_PATH environment variable isn't set, Git will use
> the path that was compiled in when it was built
> - If that Git is installed in a different path (i.e. compiled for
> /usr/local but installed in /opt), the compiled-in exec path may not
> exist or not contain "git"
> - In that case, "git" gets run from wherever it's found in $PATH and
> you get whatever version that happens to be
> 
> Does something like that seem like it could happen?

Yes, that's quite plausible. One easy way to trigger that is to run Git out of the build directory without a "make install". That's why we have the bin-wrappers/ subdirectory, which sets up the exec-path to use the built-but-not-installed version (and that's what we use when running the test suite).

-Peff