git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv1 0/6] git-p4: wait() for child processes better

From
Luke Diamand <luke@diamand.org>
Date
Jan 29, 2020, 11:12 UTC
Message-ID
<20200129111246.12196-1-luke@diamand.org>

git-p4 handles most errors by calling die(). This can leave child processes still running, orphaned.

    https://public-inbox.org/git/20190227094926.GE19739@szeder.dev/
This is not a problem for humans, but for CI, it is.

This change improves things by raising an exception and cleaning up further up the stack, rather than simply calling die().

This is only done in a few places, such that the tests pass with the changes suggested in the link (adding sleep strategically) but there are still plenty of places where git-p4 calls die().

This also adds some pylint disables, so that we can start to run pylint on git-p4.

Luke Diamand (6):
  git-p4: make closeStreams() idempotent
  git-p4: add P4CommandException to report errors talking to Perforce
  git-p4: disable some pylint warnings, to get pylint output to
    something manageable
  git-p4: create helper function importRevisions()
  git-p4: cleanup better on error exit
  git-p4: check for access to remote host earlier
 git-p4.py | 180 +++++++++++++++++++++++++++++++++---------------------
 1 file changed, 109 insertions(+), 71 deletions(-)
-- 
2.20.1.390.gb5101f9297
Next: Luke Diamand
Message 1 of 13 in “[PATCHv1 0/6] git-p4: wait() for child processes better”
  1. Luke DiamandJan 29, 2020
  2. 1/6 git-p4: make closeStreams() idempotentLuke Diamand, Jan 29, 2020
  3. 2/6 git-p4: add P4CommandException to report errors talking to PerforceLuke Diamand, Jan 29, 2020
  4. 3/6 git-p4: disable some pylint warnings, to get pylint output to something manageableLuke Diamand, Jan 29, 2020
  5. 4/6 git-p4: create helper function importRevisions()Luke Diamand, Jan 29, 2020
  6. 5/6 git-p4: cleanup better on error exitLuke Diamand, Jan 29, 2020
  7. 6/6 git-p4: check for access to remote host earlierLuke Diamand, Jan 29, 2020
  8. Eric SunshineJan 29, 2020
  9. Luke DiamandJan 29, 2020
  10. Junio C HamanoJan 30, 2020
  11. Luke DiamandJan 31, 2020
  12. Johannes SchindelinJan 30, 2020
  13. Luke DiamandJan 30, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.