Re: [PATCH] doc: clarify "explicitly given" in push.default
- From
Jeff King <peff@peff.net>
- Date
- Jan 27, 2020, 07:02 UTC
- Message-ID
- <20200127070238.GA32427@coredump.intra.peff.net>
- In-Reply-To
- <d8007df9-002b-6db1-4769-d6bf8c338cdf@googlemail.com>
On Mon, Jan 27, 2020 at 08:00:22AM +0100, Bert Wesarg wrote:
Show 27 quoted lines
> > diff --git a/Documentation/config/push.txt b/Documentation/config/push.txt > > index 0a0e000569..554ab44b4c 100644 > > --- a/Documentation/config/push.txt > > +++ b/Documentation/config/push.txt > > @@ -1,6 +1,7 @@ > > push.default:: > > Defines the action `git push` should take if no refspec is > > - explicitly given. Different values are well-suited for > > + explicitly given (either on the command-line or via a > > + `remote.*.push` config option). Different values are well-suited for > > specific workflows; for instance, in a purely central workflow > > `upstream` is probably what you want. Possible values are: > > > > I would rather talk about 'implicitly given', if it is via a `remote.*.push` config option: > > Defines the action `git push` should take if no refspec is > - explicitly given. Different values are well-suited for > - specific workflows; for instance, in a purely central workflow > - (i.e. the fetch source is equal to the push destination), > - `upstream` is probably what you want. Possible values are: > + neither explicitly (on the command-line) nor implicitly (via a > + `remote.*.push` config option) given. Different values are > + well-suited for specific workflows; for instance, in a purely > + central workflow (i.e. the fetch source is equal to the push > + destination), `upstream` is probably what you want. Possible > + values are:
Yeah, that sounds fine. Want to wrap it up with as a patch with a commit message?
-Peff