Re: [PATCH] clean: demonstrate a bug with pathspecs

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 16, 2020, 00:03 UTC
Message-ID: <20200116000312.GD146834@google.com>
In-Reply-To: <pull.526.git.1579119946211.gitgitgadget@gmail.com>

Hi,

Derrick Stolee wrote:

Show 8 quoted lines

> b9660c1 (dir: fix checks on common prefix directory, 2019-12-19)
> modified the way pathspecs are handled when handling a directory
> during "git clean -f <path>". While this improved the behavior
> for known test breakages, it also regressed in how the clean
> command handles cleaning a specified file.
>
> Add a test case that demonstrates this behavior. This test passes
> before b9660c1 then fails after.

Can this commit message say a little more about the nature of the bug? For example, what kind of workflow does this come up in for end users?

[...]

>     While integrating v2.25.0 into the microsoft/git fork, one of our VFS
>     for Git functional tests started failing.

This is also useful information to put in the commit message: e.g. "Noticed via VFS for Git's functional test <test name>". It provides useful context when looking at such a patch later.

[...]

>                                      Elijah is CC'd in case he still has
>     context on this area.

Thanks and hope that helps, Jonathan