git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 02/24] t3206: make hash size independent

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jan 13, 2020, 12:38 UTC
Message-ID
<20200113123857.3684632-3-sandals@crustytoothpaste.net>
In-Reply-To
<20200113123857.3684632-1-sandals@crustytoothpaste.net>

Fix the one assertion in this test that still uses SHA-1 to use test_oid to be independent of the hash.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t3206-range-diff.sh | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
index 0575dd72b1..bd808f87ed 100755
--- a/t/t3206-range-diff.sh
+++ b/t/t3206-range-diff.sh
@@ -102,6 +102,14 @@ test_expect_success 'setup' '
 	n3 sha256:3b0a644
 	n4 sha256:e461653
 
+	# mode change
+	o1 sha1:4d39cb3
+	o2 sha1:26c107f
+	o3 sha1:4c1e0f5
+	o1 sha256:d0dd598
+	o2 sha256:c4a279e
+	o3 sha256:78459d7
+
 	# added and removed
 	s1 sha1:096b1ba
 	s2 sha1:d92e698
@@ -336,7 +344,7 @@ test_expect_success 'renamed file' '
 test_expect_success 'file with mode only change' '
 	git range-diff --no-color --submodule=log topic...mode-only-change >actual &&
 	sed s/Z/\ /g >expect <<-EOF &&
-	1:  fccce22 ! 1:  4d39cb3 s/4/A/
+	1:  $(test_oid t2) ! 1:  $(test_oid o1) s/4/A/
 	    @@ Metadata
 	    ZAuthor: Thomas Rast <trast@inf.ethz.ch>
 	    Z
@@ -352,7 +360,7 @@ test_expect_success 'file with mode only change' '
 	    Z 7
 	    +
 	    + ## other-file (new) ##
-	2:  147e64e ! 2:  26c107f s/11/B/
+	2:  $(test_oid t3) ! 2:  $(test_oid o2) s/11/B/
 	    @@ Metadata
 	    ZAuthor: Thomas Rast <trast@inf.ethz.ch>
 	    Z
@@ -368,7 +376,7 @@ test_expect_success 'file with mode only change' '
 	    Z 14
 	    +
 	    + ## other-file (mode change 100644 => 100755) ##
-	3:  a63e992 = 3:  4c1e0f5 s/12/B/
+	3:  $(test_oid t4) = 3:  $(test_oid o3) s/12/B/
 	EOF
 	test_cmp expect actual
 '
Previous: brian m. carlsonNext: brian m. carlson
Message 3 of 36 in “SHA-256 test fixes, part 8”
  1. 00/24 SHA-256 test fixes, part 8brian m. carlson, Jan 13, 2020
  2. 01/24 t/lib-pack: support SHA-256brian m. carlson, Jan 13, 2020
  3. 02/24 t3206: make hash size independentbrian m. carlson, Jan 13, 2020
  4. 08/24 t3404: remove SHA1 prerequisitebrian m. carlson, Jan 13, 2020
  5. 07/24 t3311: make test work with SHA-256brian m. carlson, Jan 13, 2020
  6. 11/24 t4211: make test hash independentbrian m. carlson, Jan 13, 2020
  7. 05/24 t3309: make test work with SHA-256brian m. carlson, Jan 13, 2020
  8. 12/24 t5302: make hash size independentbrian m. carlson, Jan 13, 2020
  9. 09/24 t4013: make test hash independentbrian m. carlson, Jan 13, 2020
  10. 03/24 t3305: annotate with SHA1 prerequisitebrian m. carlson, Jan 13, 2020
  11. 10/24 t4060: make test work with SHA-256brian m. carlson, Jan 13, 2020
  12. 06/24 t3310: make test work with SHA-256brian m. carlson, Jan 13, 2020
  13. 14/24 t5313: make test hash independentbrian m. carlson, Jan 13, 2020
  14. 21/24 t5703: switch tests to use test_oidbrian m. carlson, Jan 13, 2020
  15. 20/24 t5703: make test work with SHA-256brian m. carlson, Jan 13, 2020
  16. Eric SunshineJan 13, 2020
  17. brian m. carlsonJan 13, 2020
  18. 24/24 t6024: update for SHA-256brian m. carlson, Jan 13, 2020
  19. 23/24 t6006: make hash size independentbrian m. carlson, Jan 13, 2020
  20. 22/24 t6000: abstract away SHA-1-specific constantsbrian m. carlson, Jan 13, 2020
  21. 18/24 t5616: use correct filter syntaxbrian m. carlson, Jan 13, 2020
  22. t5616: make robust to delta base changeJonathan Tan, Jan 13, 2020
  23. brian m. carlsonJan 13, 2020
  24. brian m. carlsonJan 25, 2020
  25. 19/24 t5607: make hash size independentbrian m. carlson, Jan 13, 2020
  26. 16/24 t5515: make test hash independentbrian m. carlson, Jan 13, 2020
  27. 17/24 t5318: update for SHA-256brian m. carlson, Jan 13, 2020
  28. Eric SunshineJan 13, 2020
  29. brian m. carlsonJan 13, 2020
  30. 04/24 t3308: make test work with SHA-256brian m. carlson, Jan 13, 2020
  31. 15/24 t5321: make test hash independentbrian m. carlson, Jan 13, 2020
  32. 13/24 t5309: make test hash independentbrian m. carlson, Jan 13, 2020
  33. Eric SunshineJan 13, 2020
  34. brian m. carlsonJan 13, 2020
  35. Eric SunshineJan 13, 2020
  36. Johannes SchindelinJan 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.